Skip to content

fix(ci): strip trailing .0 from manual-evals numeric inputs#2154

Merged
miguelg719 merged 1 commit into
browserbase:miguelgonzalez/stg-1926-ci-evals-page-integration-2from
chromiebot:chromie/fix-the-pr-miguelgonzalez-stg-1926
May 21, 2026
Merged

fix(ci): strip trailing .0 from manual-evals numeric inputs#2154
miguelg719 merged 1 commit into
browserbase:miguelgonzalez/stg-1926-ci-evals-page-integration-2from
chromiebot:chromie/fix-the-pr-miguelgonzalez-stg-1926

Conversation

@chromiebot
Copy link
Copy Markdown
Contributor

@chromiebot chromiebot commented May 21, 2026

The GitHub iOS app dispatches workflows with numeric inputs serialized as doubles ("1.0"/"50.0") even when the receiving field is declared type: number for an integer. GitHub accepts the float and threads it into the run, so the workflow triggers, but the evals CLI's parsePositiveInteger (regex /^[0-9]+$/) then rejects the value and the job fails immediately.

Strip a single trailing .0 from EVAL_TRIALS and EVAL_CONCURRENCY in the dispatch shell before forwarding them to the eval CLI. Integers and non-zero decimals are passed through unchanged, so behaviour for the web UI / API callers is identical.


Summary by cubic

Strip a trailing .0 from EVAL_TRIALS and EVAL_CONCURRENCY in the manual-evals workflow so the evals CLI accepts integer inputs. Prevents job failures when the GitHub iOS app sends numeric inputs as doubles (e.g., "1.0", "50.0").

Written for commit c6c1d73. Summary will update on new commits. Review in cubic

The GitHub iOS app dispatches workflows with numeric inputs serialized
as doubles ("1.0"/"50.0") even when the receiving field is declared
`type: number` for an integer. GitHub accepts the float and threads it
into the run, so the workflow triggers, but the evals CLI's
`parsePositiveInteger` (regex /^[0-9]+$/) then rejects the value and
the job fails immediately.

Strip a single trailing `.0` from `EVAL_TRIALS` and `EVAL_CONCURRENCY`
in the dispatch shell before forwarding them to the eval CLI. Integers
and non-zero decimals are passed through unchanged, so behaviour for
the web UI / API callers is identical.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 21, 2026

⚠️ No Changeset found

Latest commit: c6c1d73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.

@github-actions github-actions Bot added external-contributor Tracks PRs mirrored from external contributor forks. external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. labels May 21, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@miguelg719 miguelg719 merged commit 2c88217 into browserbase:miguelgonzalez/stg-1926-ci-evals-page-integration-2 May 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. external-contributor Tracks PRs mirrored from external contributor forks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants