[chore]: bump ws dep#2169
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Root as Monorepo Root
participant Turbo as Turbo Build System
participant CLI as CLI Package
participant Core as Core Package
participant Mintlify as Mintlify Dep (transitive)
participant Braintrust as Braintrust Dep (transitive)
Note over Root,Braintrust: Dependency Resolution Flow
Root->>Root: Define overrides (ws@^8.20.1, qs@^6.15.2)
Root->>Turbo: turbo run (build/test/lint)
Turbo->>CLI: Resolve dependency tree
Turbo->>Core: Resolve dependency tree
alt Package has direct ws dependency
CLI->>CLI: ws@^8.21.0 (direct dep)
Core->>Core: ws@^8.21.0 (direct dep)
else Transitive ws from external packages
CLI->>Mintlify: uses ws (transitive)
Mintlify->>Root: override applied
Root-->>Mintlify: ws@^8.20.1 (resolved via override)
Core->>Braintrust: uses ws (transitive)
Braintrust->>Root: override applied
Root-->>Braintrust: ws@^8.20.1 (resolved via override)
end
Note over CLI,Core: Runtime ws Usage
CLI->>Core: WebSocket connection (uses ws)
Core->>Core: ws.send() / ws.on('message')
alt Secure ws connection established
CLI-->>Core: WebSocket handshake (upgraded ws version)
Core-->>CLI: Data frames (patched security)
else Connection error (unlikely due to backwards-compatible bump)
CLI->>CLI: Retry / fallback logic
end
Note over Mintlify,Braintrust: qs override (similar pattern)
Mintlify->>Root: queries qs (transitive)
Root-->>Mintlify: qs@^6.15.2 (overridden version)
Braintrust->>Root: queries qs (transitive)
Root-->>Braintrust: qs@^6.15.2 (overridden version)
tkattkat
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
ws& a few other deps to versions with various security patcheswhat changed
wsdep from^8.18.0to^8.21.0^2.8.10to^2.9.15qs&wswhich are transitive deps brought in by mintlify & braintrustqs&wsversionsSummary by cubic
Upgrade
wsto patched versions across the repo and add overrides for transitivewsandqsto address security fixes. Also bumpturboto the latest minor.packages/cliandpackages/core:ws^8.18.0 -> ^8.21.0ws^8.20.1,qs^6.15.2 (to override transitive deps frommintlifyandbraintrust)turbo^2.8.10 -> ^2.9.15Written for commit e8f6ff1. Summary will update on new commits. Review in cubic