Skip to content

Conversation

@CtrlAltGiri
Copy link
Contributor

@CtrlAltGiri CtrlAltGiri commented Apr 20, 2025

why

Adding zod validation errors in the error response to ensure better debugging for developers.

Resolving issue: #689

what changed

  1. Adding a new ZodValidationError.
  2. Stringifying the JSON in the ValidationError.

test plan

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2025

⚠️ No Changeset found

Latest commit: 36b77de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added Zod schema validation across LLM clients to provide consistent, type-safe response handling and improved error reporting.

  • Added new types/zod.ts with validateZodSchemaWithResult utility for standardized schema validation
  • Introduced CreateChatCompletionResponseValidationError for structured validation failures
  • Implemented consistent validation in both GoogleClient and OpenAIClient with detailed error messages
  • Added retry mechanism when validation fails in both LLM clients
  • Aligned validation approach between providers while maintaining provider-specific response handling

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@seanmcguire12
Copy link
Member

Hey @CtrlAltGiri thanks for this PR! Going to push a couple changes to your branch here so that we can get this over the line

@seanmcguire12 seanmcguire12 changed the base branch from main to evals/CtrlAltGiri/stagehand-zod-validation May 9, 2025 17:30
@seanmcguire12 seanmcguire12 merged commit c8cd199 into browserbase:evals/CtrlAltGiri/stagehand-zod-validation May 9, 2025
seanmcguire12 added a commit that referenced this pull request May 12, 2025
* Adding zod validation (#690)

* Stagehand commits'

* Update types/zod.ts

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* using format()

* minor update

* minor update

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* add zodValidationError

* use safeparse and throw informed error

* changeset

---------

Co-authored-by: Giridhar Balachandran <giridhar.balaz@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants