Skip to content

Conversation

@seanmcguire12
Copy link
Member

why

  • we used to scroll inside of extract to render content
  • now, we dont scroll automatically, so this eval was failing (not rendering enough content)

what changed

  • added an act step to scroll & render more content. eval passes now.

test plan

  • this is it

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2025

⚠️ No Changeset found

Latest commit: c048c54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added scrolling functionality to extract_collaborators.ts to handle the removal of automatic scrolling in extract functionality. The changes include:

  • Added stagehand.page.act() to scroll halfway down the page before extraction
  • Added waitForLoadState and waitForTimeout calls to ensure content is loaded
  • Potential concerns with hardcoded 5-second timeout and imprecise scroll positioning
  • Risk of test fragility due to dependency on specific contributor ordering
  • Could benefit from more robust error handling around JSON stringification

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@seanmcguire12 seanmcguire12 merged commit 4ad64f6 into main May 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants