Sydshields/dash 1732 turn existing templates in js files#95
Merged
syd-shields merged 2 commits intoMay 13, 2026
Merged
Conversation
…le places to prevent drift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing CI
Note
Medium Risk
Moderate risk because it changes how filtered builds clean
javascript/output and howpackage.jsonscripts.buildis rewritten, which could unintentionally delete or alter generated template artifacts.Overview
Refactors
scripts/build-javascript.mjsto parse CLI filter flags once (parseBuildOptions) and reuse the resulting options for both file filtering and output cleanup, keeping partial rebuild behavior consistent when using include/exclude template or path flags.Updates
package.jsonadaptation to safely drop a leading compile-onlytscfromscripts.build: it now removes the script only when it’s justtsc, or preserves any chained commands after&&/||/;so downstream steps (e.g.next build) remain.Reviewed by Cursor Bugbot for commit 2a862c0. Bugbot is set up for automated code reviews on this repo. Configure here.