Skip to content

Conversation

eiriksm
Copy link

@eiriksm eiriksm commented Aug 1, 2014

This is the PR mentioned in #59

@eiriksm
Copy link
Author

eiriksm commented Aug 1, 2014

Also added a test case for this.

It is admittedly a bit more monkey patched than the rest of the tests in the test suite, but at least it proves the point: It fails with current codebase and passes on the patched.

I tried to match the coding style in the tests as well, but I am happy to change it around if you feel differently about something there.

@eiriksm
Copy link
Author

eiriksm commented Aug 3, 2014

Very shamelessly pinging @maxogden , since I saw that's where the code in question came from.

Also noting that this is not because I think 2 days is a long time to wait for a PR to be responded to, just I know substack has 1M projects. Hm, probably applies to maxogden too. Oh well.

@tmpvar
Copy link

tmpvar commented Sep 24, 2014

+1 just ran into this with while requesting http://wzrd.in/standalone/concat-stream@latest

@eiriksm's fix looks good - @substack can we get some love here?

@eiriksm eiriksm force-pushed the bug/arraybuffer-in-string branch from 6b59bc8 to 608b3e2 Compare September 26, 2014 07:29
@eiriksm
Copy link
Author

eiriksm commented Sep 26, 2014

Thanks for that @tmpvar

Just noticed my pull request contained merge conflicts. Now updated against latest master

@esundahl
Copy link

Any chance at getting this merged? Thanks

@tmpvar
Copy link

tmpvar commented Nov 12, 2014

bump

@hughsk
Copy link
Member

hughsk commented Nov 12, 2014

+1

@Janpot
Copy link

Janpot commented Nov 16, 2014

Having the same issue

@eiriksm
Copy link
Author

eiriksm commented Mar 6, 2015

Just shamelessly bumping this. And for those who only have read this and not my original bug report: Here is also a POC site that explains the problem with an example: https://eiriksm.github.io/browserify-test/

@eiriksm
Copy link
Author

eiriksm commented Jan 26, 2016

This bug is no longer a problem in latest browserify. It was probably fixed when browserify switched to stream-http instead of this package.

So as a reference, for anyone randomly coming here so long after it was fixed: You should probably upgrade browserify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants