-
Notifications
You must be signed in to change notification settings - Fork 107
Support "ArrayBuffer" to be part of the string. #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also added a test case for this. It is admittedly a bit more monkey patched than the rest of the tests in the test suite, but at least it proves the point: It fails with current codebase and passes on the patched. I tried to match the coding style in the tests as well, but I am happy to change it around if you feel differently about something there. |
Very shamelessly pinging @maxogden , since I saw that's where the code in question came from. Also noting that this is not because I think 2 days is a long time to wait for a PR to be responded to, just I know substack has 1M projects. Hm, probably applies to maxogden too. Oh well. |
+1 just ran into this with while requesting http://wzrd.in/standalone/concat-stream@latest @eiriksm's fix looks good - @substack can we get some love here? |
6b59bc8
to
608b3e2
Compare
Thanks for that @tmpvar Just noticed my pull request contained merge conflicts. Now updated against latest master |
Any chance at getting this merged? Thanks |
bump |
+1 |
Having the same issue |
Just shamelessly bumping this. And for those who only have read this and not my original bug report: Here is also a POC site that explains the problem with an example: https://eiriksm.github.io/browserify-test/ |
This bug is no longer a problem in latest browserify. It was probably fixed when browserify switched to stream-http instead of this package. So as a reference, for anyone randomly coming here so long after it was fixed: You should probably upgrade browserify. |
This is the PR mentioned in #59