Skip to content

Support "ArrayBuffer" to be part of the string. #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Support "ArrayBuffer" to be part of the string. #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16cbc72
Support "ArrayBuffer" to be part of the string.
eiriksm Aug 1, 2014
608b3e2
Add a test case for string with "ArrayBuffer" in them.
eiriksm Aug 1, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Response.prototype.handle = function (res) {

Response.prototype._emitData = function (res) {
var respBody = this.getResponse(res);
if (respBody.toString().match(/ArrayBuffer/)) {
if (Object.prototype.toString.call(respBody) === '[object ArrayBuffer]') {
this.emit('data', new Uint8Array(respBody, this.offset));
this.offset = respBody.byteLength;
return;
Expand Down
14 changes: 14 additions & 0 deletions test/request_url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,17 @@ test('Test POST XHR2 types', function(t) {
};
request.end(new global.FormData());
});

test('Test strings with "ArrayBuffer" in them', function(t) {
var Response = require('../lib/response');
var res = new Response;
var testString = 'I am a string with the word ArrayBuffer';
// Monkey patch response object.
res.emit = function(e, d) {
if (e === 'data') {
t.equal( d, testString, 'Emitted data should equal testString');
t.end();
}
};
res.handle({readyState: 4, responseText: testString});
});