Skip to content

chore: update destructiveHint annotations for various tools#94

Merged
andyMrtnzP merged 2 commits into
mainfrom
chore/surface-hints
May 27, 2026
Merged

chore: update destructiveHint annotations for various tools#94
andyMrtnzP merged 2 commits into
mainfrom
chore/surface-hints

Conversation

@andyMrtnzP
Copy link
Copy Markdown
Contributor

@andyMrtnzP andyMrtnzP commented May 27, 2026

Summary by CodeRabbit

  • Chores
    • Updated operational metadata annotations across multiple tools to refine destructive/read-only hints for client/UI handling (no functional or API changes).
    • Extended default allowed redirect URIs to include additional ChatGPT/OpenAI connector patterns.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b24136b-9f0f-4d0e-80fa-eeaed26f532f

📥 Commits

Reviewing files that changed from the base of the PR and between 2a5e308 and 50ed64a.

📒 Files selected for processing (1)
  • src/config.ts

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

Tool registrations gain explicit destructiveHint annotations (true for agent/download/function; false for crawl/export/map/performance/search/smartscraper/skill). Additionally, ChatGPT connector redirect URI patterns were added to the default allow-list. No execution logic or public APIs changed.

Changes

Tool metadata destructive hints and config allow-list

Layer / File(s) Summary
Destructive action tools
src/tools/agent.ts, src/tools/download.ts, src/tools/function.ts
browserless_agent, browserless_download, and browserless_function tool registrations now set destructiveHint: true.
Read-only and safe operation tools
src/tools/agent.ts, src/tools/crawl.ts, src/tools/export.ts, src/tools/map.ts, src/tools/performance.ts, src/tools/search.ts, src/tools/smartscraper.ts
browserless_skill, browserless_crawl, browserless_export, browserless_map, browserless_performance, browserless_search, and browserless_smartscraper registrations now set destructiveHint: false.
OAuth redirect allow-list update
src/config.ts
DEFAULT_ALLOWED_REDIRECT_URI_PATTERNS now includes ChatGPT/OpenAI connector patterns (https://chatgpt.com/connector/oauth/* and https://chatgpt.com/connector_platform_oauth_redirect).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • artiom
  • ahmedAmien
  • Adriansillo

Poem

🐰 A hop, a tweak, annotations neat,

True where it changes, false where it reads,
Redirects widened to greet ChatGPT's beat,
Small edits that keep the toolset complete,
A rabbit applauds these tidy deeds.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description; required sections like Summary, Related issues, Changes, Test plan, and Checklist are completely missing. Add a comprehensive description following the template, including a summary of changes, related issues, test plan verification, and confirmation of the checklist items.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding destructiveHint annotations to multiple tools.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/surface-hints

Comment @coderabbitai help to get the list of available commands and usage tips.

@andyMrtnzP andyMrtnzP merged commit b21484f into main May 27, 2026
0 of 2 checks passed
@andyMrtnzP andyMrtnzP deleted the chore/surface-hints branch May 27, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant