-
Notifications
You must be signed in to change notification settings - Fork 992
Ability to set number of pre-boot "warm" instances separate from the maximum concurrent instances #3344
Description
Is your feature request related to a problem? Please describe.
At present the number of pre-boot / "warm" instances to have running is hardcoded to be the same as the maximum concurrent instances.
I'm sure there was some logic as to why this was done, but from a scaling and resource usage perspective it would be advantageous to be able to separately configure these.
For example:
- If you have a machine that has limited memory.
- You need at least one warm chrome instance.
- In my case it's for changedetection.io which seems to only work with warm instances.
- You want it to scale from 1 to say 10 maximum concurrent instances.
Right now, you're limited to setting MAX_CONCURRENT_SESSIONS which configures both.
This means if you only want the persistent memory usage of one chrome instance (about 220Mb it seems) when idle as it's quite a lot of wasted memory that could be used for active tasks - you're limited to a maximum concurrency at any time of 1.
Describe the solution you'd like
Replace preboot_chrome with a variable that can set the number of preboot instances.
PREBOOT_INSTANCES- Set from 0 (don't warm / pre-boot chrome) to >= 1 for the number of warm instances to start.MAX_CONCURRENT_SESSIONS- only sets the limit for the maximum concurrent sessions.
Describe alternatives you've considered
Add another variable that sets the number of preboot instances:
preboot_instances:1
Additional context
Add any other context or screenshots about the feature request here.