Skip to content

Upgrade emsdk#90

Merged
XapaJIaMnu merged 2 commits intobrowsermt:masterfrom
abhi-agg:upgrade-emsdk
Apr 12, 2022
Merged

Upgrade emsdk#90
XapaJIaMnu merged 2 commits intobrowsermt:masterfrom
abhi-agg:upgrade-emsdk

Conversation

@abhi-agg
Copy link
Copy Markdown

@abhi-agg abhi-agg commented Apr 12, 2022

Description

Fixes #89

List of changes:

  • Upgrade emsdk version from 2.0.9 to 3.1.8
  • Updated cmake files to follow strict separation b/w compile and link flags

Added dependencies: none

How to test

Followed README instructions to run marian-decoder executable in Firefox browser to see translations in console logs.

Checklist

  • I have tested the code manually
  • I have run regression tests
  • I have read and followed CONTRIBUTING.md
  • I have updated CHANGELOG.md

@jelmervdl Thanks for inspiring this change.

Copy link
Copy Markdown
Member

@jelmervdl jelmervdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XapaJIaMnu XapaJIaMnu merged commit 199201e into browsermt:master Apr 12, 2022
@abhi-agg abhi-agg deleted the upgrade-emsdk branch April 12, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade emsdk to the latest tag

3 participants