Closed
Conversation
Author
|
For anyone interested: Also added:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I rewrote the plugin in Kotlin and optimised some part:
registerinstead ofcreatetask. The task won't be created until actually used (see gradle doc)I didn't touch the json/http packages, should probably but rewritten with retrofit/moshi one day for maintanability.
I'm using it in locale and it works fine, feel free to test.
If you prefer to keep it in java, just close the PR.
Some notes:
appandtestSuiteproperties are not implicitly saved and passed anymore. The calling function now saves the value and pass it to next functionsprojectcapabilities as requested in Add project parameters to EspressoTask #23I also added a parameter to poll the end of the test in my local fork. Let me know if you're interested in merging that as well.
The process is holding until the execution is finished. The task polls at a regular interval to check the status. Then it downloads the test result file in local
test-resultsdirectory