refactor: replacing access type with access tag #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into user_identity_access_processing
Adding a new grant and revoke method, adding transactions scope for offboarding
…into user_identity_access_processing
… unrequired params, using the new method for access grant
vedharish
previously approved these changes
Feb 17, 2023
Access/userlist_helper.py
Outdated
| for mapping in new_user_access_mapping: | ||
| if mapping.is_approved(): | ||
| accept_request(user_access_mapping = mapping) | ||
| accept_request(user_access_mapping = mapping, is_migrated=True) |
Contributor
There was a problem hiding this comment.
approval_type parameter in accept_request has no default value
Contributor
There was a problem hiding this comment.
Do we need to pass approver as well? since default value is None and its passed to "processing" method.
Contributor
Author
There was a problem hiding this comment.
no need to pass it in case of migration, this is handled inside the function
| raise Exception("Request Not approved") | ||
|
|
||
| user_access_mapping.processing() | ||
| user_access_mapping.processing(approval_type = approval_type, approver=approver) |
Contributor
There was a problem hiding this comment.
in case of __change_identity_and_transfer_access_mapping (is_migrated=true) , do we need to set approvers again?
Do we need to handle that case separately in processing() method? or we can remove setting approver from processing method.
larsendsouza
approved these changes
Feb 17, 2023
niveshm
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing unused parameters, using the new method for access grant.
moving the approval type check and status change code to models
adding the call to the accept_request in the accept access request function