Skip to content

Feat: Pending actions UI improvements#78

Merged
vedharish merged 10 commits into
ui-improvementsfrom
user-profile-ui
Jun 6, 2023
Merged

Feat: Pending actions UI improvements#78
vedharish merged 10 commits into
ui-improvementsfrom
user-profile-ui

Conversation

@niveshm
Copy link
Copy Markdown
Contributor

@niveshm niveshm commented Feb 21, 2023

No description provided.

Copy link
Copy Markdown
Collaborator

@vedharish vedharish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the PendingActions count on the sidebar in global_layout for total actions pending

image

Comment thread templates/BSOps/pendingRequests.html Outdated
Comment thread templates/global_layout.html Outdated
Comment thread templates/BSOps/pendingRequests.html Outdated
Comment thread templates/BSOps/pendingRequests.html Outdated
</div><br>
<div class="overflow-hidden bg-white shadow sm:rounded-md">
<ul role="list" class="divide-y divide-gray-200">
<li>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check if we need to show empty dropdowns for 0 action items

image

Comment thread templates/BSOps/pendingRequests.html Outdated
@niveshm
Copy link
Copy Markdown
Contributor Author

niveshm commented Feb 21, 2023

Can you also update the PendingActions count on the sidebar in global_layout for total actions pending

image

@niveshm niveshm closed this Feb 21, 2023
@niveshm niveshm reopened this Feb 21, 2023
Comment thread Access/accessrequest_helper.py
Comment thread static/js/pendingRequests.js Outdated
Comment thread static/js/pendingRequests.js Outdated
Copy link
Copy Markdown
Collaborator

@vedharish vedharish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-05-15 at 8 47 37 PM
  1. The notes bars are too wide
  2. Cant see the request timestamp in request id
  3. The down-arrow for collapsible sections needs to change to right-arrows when collapsed

@vedharish
Copy link
Copy Markdown
Collaborator

The url http://localhost:8000/group/dashboard/ is breaking on this PR

@vedharish vedharish merged commit 2b34a35 into ui-improvements Jun 6, 2023
@vedharish vedharish deleted the user-profile-ui branch June 6, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants