security: patch protobufjs, basic-ftp, lodash (APS-18801, APS-18762, APS-18683)#72
Merged
karanshah-browserstack merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
Bumps three transitive dependencies in package-lock.json via `npm audit fix` (non-breaking, no changes to package.json): - protobufjs 7.2.5 -> 7.5.5 (APS-18801, GHSA-xq3m-2v4x-88gg, RCE) - basic-ftp 5.2.0 -> 5.3.0 (APS-18762, GHSA-chqc-8p9q-pq6q, CRLF injection) - lodash 4.17.21 -> 4.18.1 (APS-18683, GHSA-r5fr-rjxr-66jc, code injection) Verified end-to-end on BrowserStack — sample Playwright suite passes 3/3 across Win11 Chrome, OS X Ventura playwright-webkit, Win11 playwright-firefox. Build: https://automate.browserstack.com/dashboard/v2/builds/b357e4e033cee6b53239c969632d603ffa481031 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
avinash-bharti
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps three transitive dependencies in
package-lock.jsonvianpm audit fix(non-breaking, no changes topackage.json):protobufjs7.2.5 → 7.5.5 — APS-18801 — GHSA-xq3m-2v4x-88gg — Critical (RCE via crafted protobuf type names)basic-ftp5.2.0 → 5.3.0 — APS-18762 — GHSA-chqc-8p9q-pq6q — High (FTP Command Injection via CRLF)lodash4.17.21 → 4.18.1 — APS-18683 — GHSA-r5fr-rjxr-66jc — High (code injection via_.templateimports key names)Verified with
npm audit— all three target advisories are resolved. Remaining unfixed advisories are pre-existing@tootallnate/once/aws-sdkchains that require a breaking change tobrowserstack-node-sdkand are out of scope for these tickets.Test plan
Ran the repo's sample Playwright suite against BrowserStack after upgrading — full SDK + transitive deps exercised end-to-end:
npm installcleannpm audit— protobufjs, basic-ftp, lodash advisories no longer listednpm run sample-test→ 3 passed (20.5s) across Win 11 Chrome, OS X Ventura playwright-webkit, Win 11 playwright-firefoximportskey now throwsInvalid 'imports' option passed into '_.template'instead of executing injected code🤖 Generated with Claude Code