Skip to content

Selenium-3#3

Merged
francisf merged 13 commits intobrowserstack:mainfrom
RutvikChandla:selenium-3
Apr 12, 2022
Merged

Selenium-3#3
francisf merged 13 commits intobrowserstack:mainfrom
RutvikChandla:selenium-3

Conversation

@RutvikChandla
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@Ankit098 Ankit098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address the same issues here as mentioned in comments in #2

@RutvikChandla RutvikChandla requested a review from Ankit098 April 11, 2022 05:22
@RutvikChandla
Copy link
Copy Markdown
Contributor Author

@Ankit098 Please review, changes are done.

Copy link
Copy Markdown
Collaborator

@Ankit098 Ankit098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added a few more comments, other than that looks good.
Also let's rename scripts folder to specs or tests.

Comment thread README.md
Comment thread README.md Outdated
Comment thread conf.js Outdated
Comment thread conf.js Outdated
Comment thread package.json Outdated
Comment thread scripts/local.js Outdated
Comment thread scripts/local.js Outdated
Comment thread scripts/parallel.js Outdated
Comment thread scripts/parallel.js Outdated
Comment thread scripts/parallel.js Outdated
@RutvikChandla
Copy link
Copy Markdown
Contributor Author

@Ankit098 Please review

Comment thread tests/local.js Outdated
Comment thread tests/parallel.js Outdated
Comment thread tests/single.js Outdated
Comment thread tests/single.js
Comment thread tests/local.js Outdated
Comment thread tests/local.js Outdated
Comment thread tests/local.js Outdated
Comment thread tests/parallel.js Outdated
Comment thread tests/parallel.js Outdated
Comment thread tests/single.js Outdated
RutvikChandla and others added 2 commits April 11, 2022 15:46
Co-authored-by: Ankit Singh <51696887+Ankit098@users.noreply.github.com>
@RutvikChandla RutvikChandla requested a review from Ankit098 April 11, 2022 10:18
Ankit098
Ankit098 previously approved these changes Apr 11, 2022
Copy link
Copy Markdown
Collaborator

@Ankit098 Ankit098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread package.json Outdated
@RutvikChandla
Copy link
Copy Markdown
Contributor Author

@sreenivas-k Please review.

sreenivas-k
sreenivas-k previously approved these changes Apr 12, 2022
@RutvikChandla RutvikChandla requested a review from Ankit098 April 12, 2022 06:05
@francisf francisf merged commit 61f652f into browserstack:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants