Skip to content

Enhancing Windows Tests on phpUnit#17

Merged
francisf merged 8 commits intobrowserstack:masterfrom
hari-haran-ss:master
Oct 3, 2023
Merged

Enhancing Windows Tests on phpUnit#17
francisf merged 8 commits intobrowserstack:masterfrom
hari-haran-ss:master

Conversation

@hari-haran-ss
Copy link
Copy Markdown
Contributor

@hari-haran-ss hari-haran-ss commented Sep 29, 2023

Description:

  • PR is to fix windows compatibility issues in running php-unit.
  • The current repo works fine for mac, but not for windows.
  • Handled the commands of scripts in composer json to a php file, as env variable setting is different for mac and windows. So, handled it generically to a php file (triggerTest.php).
  • Similarly handled the system command execution based on OS for both win and mac /linux in runner.php.
  • Fixed taskid conversion to int inside array pointer, as it passes string in windows.

@hari-haran-ss hari-haran-ss requested a review from a team as a code owner September 29, 2023 13:13
@karanshah-browserstack
Copy link
Copy Markdown
Collaborator

Please raise a similar pr for selenium-3 branch too

@francisf francisf merged commit e53c418 into browserstack:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants