Adding playwright test documentation #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanshah-browserstack
force-pushed
the
playwright-test
branch
from
d61578b to
9a0e047
Compare
sourav-kundu
suggested changes
Sep 23, 2021
playwright-test/global-setup.js
Outdated
Comment on lines
13
to
15
| while (!localStarted) { | ||
| await sleep(1000); | ||
| } |
There was a problem hiding this comment.
Is this wait required?
What if local fails to start?
There was a problem hiding this comment.
Throwing an error now.
There was a problem hiding this comment.
Should we exit if we fail to start the BrowserStack local? I haven't exited currently, because it also throws an error if there is any existing binary running on your system.
|
Lets not add more than 6 test cases, 1p-5q |
@SaranshBS Product team wants to add 10+ test cases to demonstrate the workers implementation too. |
|
@SaranshBS 1P-5Q guy will not face any problem...since he would be using 1 worker only. |
sourav-kundu
suggested changes
Sep 28, 2021
playwright-test/package.json
Outdated
Comment on lines
14
to
15
| "playwright": "^1.13.1", | ||
| "@playwright/test": "^1.13.1", |
There was a problem hiding this comment.
Lets not use ^ here...lets use specific versions or use ~
…rowserstack-1 into playwright-test
sourav-kundu
approved these changes
Sep 28, 2021
francisf
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.