Skip to content

Conversation

@nurdtechie98
Copy link
Contributor

  • Move to webdriverio v5
  • Change Directory structure
  • Update Readme

else
assert(false)
});
}); No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new line


capabilities: [{
"device": "iPhone 7"
"device": "iPhone 11 Pro"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify os_versions

name: 'multiple_appium_test',
build: 'webdriver-browserstack',
device: 'iPhone 7',
device: 'iPhone 11 Pro',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify os_version

name: 'local_appium_test',
build: 'webdriver-browserstack',
device: 'iPhone 7',
device: 'iPhone 11 Pro',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify os_version

else
assert(false)
});
}); No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new line

exports.config = {
user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME',
key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACC_KEY',
key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_USERNAME',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


maxInstances: 10,
commonCapabilities: {
name: 'parallel_appium_test',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add project and build as well

exclude: [],

capabilities: [{
name: 'multiple_appium_test',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

],
exclude: [],

capabilities: [{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"readme": "WendriverIO Integration with [BrowserStack](https://www.browserstack.com)",
"description": "Selenium examples for WebdriverIO and BrowserStack App Automate",
"scripts": {
"test": "npm run single && npm run local && npm run parallel",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be npm run first

README.md Outdated
Getting Started with Appium tests using WebdriverIO on BrowserStack couldn't be easier!

### Run first test:
- Switch to `run_first_test` directory under [Android examples](./android) or [iOS examples](./ios)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this, since now it has changed to run-first-test. There will be other places as well, where you have to make these changes

@@ -1,23 +1,24 @@
exports.config = {
user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@nurdtechie98 nurdtechie98 Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of specific to using webdriverio with browserstack it has to be user and key
https://webdriver.io/docs/options.html#user

name: 'single_appium_test',
build: 'webdriver-browserstack',
device: 'Samsung Galaxy S7',
device: 'Google Pixel 3',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project not added

var browserstack = require('browserstack-local');

exports.config = {
user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above comments

@@ -1,23 +1,24 @@
exports.config = {
user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above comments

exports.config = {
user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME',
key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACC_KEY',
key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACCESS_KEY',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above comments and for capabilities as well

@@ -0,0 +1,2783 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for committing package-lock.json

exports.config = {
user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME',
key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACC_KEY',
key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACCESS_KEY',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments as above for username and capabilities

@agundawar agundawar merged commit 513b54d into browserstack:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants