-
Notifications
You must be signed in to change notification settings - Fork 61
Update code samples for webdriverio #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nurdtechie98
commented
Aug 25, 2020
- Move to webdriverio v5
- Change Directory structure
- Update Readme
| else | ||
| assert(false) | ||
| }); | ||
| }); No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a new line
|
|
||
| capabilities: [{ | ||
| "device": "iPhone 7" | ||
| "device": "iPhone 11 Pro" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specify os_versions
| name: 'multiple_appium_test', | ||
| build: 'webdriver-browserstack', | ||
| device: 'iPhone 7', | ||
| device: 'iPhone 11 Pro', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specify os_version
| name: 'local_appium_test', | ||
| build: 'webdriver-browserstack', | ||
| device: 'iPhone 7', | ||
| device: 'iPhone 11 Pro', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specify os_version
| else | ||
| assert(false) | ||
| }); | ||
| }); No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add new line
| exports.config = { | ||
| user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME', | ||
| key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACC_KEY', | ||
| key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_USERNAME', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow naming conventions from this PR https://github.com/kn-neeraj/python-appium-app-browserstack/blob/python3-readme-changes/android/examples/run-first-test/config.json
|
|
||
| maxInstances: 10, | ||
| commonCapabilities: { | ||
| name: 'parallel_appium_test', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add project and build as well
| exclude: [], | ||
|
|
||
| capabilities: [{ | ||
| name: 'multiple_appium_test', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow naming conventions and all capabilities required from https://github.com/kn-neeraj/python-appium-app-browserstack/blob/python3-readme-changes/android/examples/run-first-test/config.json
| ], | ||
| exclude: [], | ||
|
|
||
| capabilities: [{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
android/package.json
Outdated
| "readme": "WendriverIO Integration with [BrowserStack](https://www.browserstack.com)", | ||
| "description": "Selenium examples for WebdriverIO and BrowserStack App Automate", | ||
| "scripts": { | ||
| "test": "npm run single && npm run local && npm run parallel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be npm run first
README.md
Outdated
| Getting Started with Appium tests using WebdriverIO on BrowserStack couldn't be easier! | ||
|
|
||
| ### Run first test: | ||
| - Switch to `run_first_test` directory under [Android examples](./android) or [iOS examples](./ios) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this, since now it has changed to run-first-test. There will be other places as well, where you have to make these changes
| @@ -1,23 +1,24 @@ | |||
| exports.config = { | |||
| user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change user to username and key to access_key. For reference, https://github.com/kn-neeraj/python-appium-app-browserstack/blob/python3-readme-changes/android/examples/run-first-test/config.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of specific to using webdriverio with browserstack it has to be user and key
https://webdriver.io/docs/options.html#user
| name: 'single_appium_test', | ||
| build: 'webdriver-browserstack', | ||
| device: 'Samsung Galaxy S7', | ||
| device: 'Google Pixel 3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project not added
| var browserstack = require('browserstack-local'); | ||
|
|
||
| exports.config = { | ||
| user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above comments
| @@ -1,23 +1,24 @@ | |||
| exports.config = { | |||
| user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above comments
| exports.config = { | ||
| user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME', | ||
| key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACC_KEY', | ||
| key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACCESS_KEY', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above comments and for capabilities as well
ios/package-lock.json
Outdated
| @@ -0,0 +1,2783 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for committing package-lock.json
| exports.config = { | ||
| user: process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME', | ||
| key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACC_KEY', | ||
| key: process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACCESS_KEY', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comments as above for username and capabilities
add project name and remove lock file
directory restructure
Minor changes in Readme and config files