-
Notifications
You must be signed in to change notification settings - Fork 6
v2 Proxy Implementation #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
francisf
merged 81 commits into
browserstack:review-branch
from
Archish27:context_redesign
Aug 27, 2021
Merged
v2 Proxy Implementation #3
francisf
merged 81 commits into
browserstack:review-branch
from
Archish27:context_redesign
Aug 27, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cluster module and minor refactoring in sender mode for disabling the wait label for connection holding. Added the error listener on the upstream connection in receiver else leading to process getting killed.
Modify the incoming request url with the target specificed in the upstream, this will be able to send the same data as per in the URL or in request headers by just changing the host.
Change the URL with the upstream config target to connect in receiver mode. This can be used to change the internal port for communication.
If the cluster is master process then only use the fork method since it is not defined in the worker process and only present in master process.
Removed host since it is already being covered in hostname key inserted by the pino logger.
Added changes to receiver mode to use a custom logic to fetch the host from the client header config. Updates to the constant file to fetch the receiver config from JSON. Added the LLD file describing the role of entities and the choice for the implementation.
`watchFile` checks for the update time in interval and does not listen for the inode change event which `watch` does.
5eb4adf to
9c8d23d
Compare
karanshah-browserstack
requested changes
Jul 28, 2021
Co-authored-by: Shashikant Kadam <shashikdm.edu@gmail.com>
shashikdm
approved these changes
Aug 17, 2021
rchougule
reviewed
Aug 17, 2021
rchougule
reviewed
Aug 17, 2021
rchougule
reviewed
Aug 17, 2021
rchougule
reviewed
Aug 17, 2021
rchougule
reviewed
Aug 17, 2021
rchougule
reviewed
Aug 17, 2021
yashLadha
reviewed
Aug 18, 2021
Co-authored-by: Rohan Chougule <rohan183chougule@gmail.com>
Co-authored-by: Rohan Chougule <rohan183chougule@gmail.com>
Co-authored-by: Rohan Chougule <rohan183chougule@gmail.com>
…connect-proxy into context_redesign
rchougule
reviewed
Aug 18, 2021
rchougule
reviewed
Aug 18, 2021
rchougule
reviewed
Aug 18, 2021
SaranshBS
approved these changes
Aug 18, 2021
bda22f7 to
af4e868
Compare
af4e868 to
439ef8d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.