Skip to content

S3 proxy#1029

Merged
Rexagon merged 3 commits intomasterfrom
s3-proxy
Feb 12, 2026
Merged

S3 proxy#1029
Rexagon merged 3 commits intomasterfrom
s3-proxy

Conversation

@pashinov
Copy link
Copy Markdown
Member

@pashinov pashinov commented Feb 4, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[Yes]

Added s3_proxy

...
"blockchain_rpc_service": {
   ...
   "s3_proxy": {
      "rate_limit": 10,
      "bandwidth_limit": "10 MiB",
   }
}
...

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full compatibility

SPECIAL DEPLOYMENT ACTIONS

Not Required


PERFORMANCE IMPACT

No impact expected


TESTS

No

@pashinov pashinov self-assigned this Feb 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1029

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1029
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1029 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 23.94366% with 162 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.34%. Comparing base (5462fa2) to head (a337840).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
core/src/blockchain_rpc/providers.rs 17.70% 79 Missing ⚠️
core/src/blockchain_rpc/service.rs 41.46% 47 Missing and 1 partial ⚠️
core/src/node/mod.rs 0.00% 21 Missing ⚠️
light-node/src/cli.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   54.45%   54.34%   -0.11%     
==========================================
  Files         402      403       +1     
  Lines       67545    67686     +141     
  Branches    67545    67686     +141     
==========================================
+ Hits        36782    36787       +5     
- Misses      28945    29079     +134     
- Partials     1818     1820       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pashinov pashinov requested review from 0xdeafbeef and Rexagon and removed request for 0xdeafbeef February 5, 2026 13:11
@pashinov pashinov force-pushed the s3-proxy branch 3 times, most recently from f400c71 to 0aa4020 Compare February 9, 2026 14:00
Comment thread core/src/blockchain_rpc/providers.rs Outdated
@pashinov pashinov requested a review from SmaGMan February 11, 2026 17:15
Comment thread core/src/blockchain_rpc/providers.rs
Comment thread core/src/blockchain_rpc/service.rs Outdated

impl<T1, T2> BlockchainRpcServiceBuilder<(T1, T2)> {
impl<T1, T2> BlockchainRpcServiceBuilder<(T1, T2, ())> {
pub fn with_rpc_provider<RP: IntoRpcProvider>(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make base provider always default and make an s3 client optional like in archives provider (with_s3_client).

@Rexagon Rexagon added this pull request to the merge queue Feb 12, 2026
Merged via the queue into master with commit ae71673 Feb 12, 2026
21 of 23 checks passed
@Rexagon Rexagon deleted the s3-proxy branch February 12, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants