Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=1029Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 54.45% 54.34% -0.11%
==========================================
Files 402 403 +1
Lines 67545 67686 +141
Branches 67545 67686 +141
==========================================
+ Hits 36782 36787 +5
- Misses 28945 29079 +134
- Partials 1818 1820 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f400c71 to
0aa4020
Compare
SmaGMan
reviewed
Feb 11, 2026
Rexagon
requested changes
Feb 11, 2026
|
|
||
| impl<T1, T2> BlockchainRpcServiceBuilder<(T1, T2)> { | ||
| impl<T1, T2> BlockchainRpcServiceBuilder<(T1, T2, ())> { | ||
| pub fn with_rpc_provider<RP: IntoRpcProvider>( |
Member
There was a problem hiding this comment.
Make base provider always default and make an s3 client optional like in archives provider (with_s3_client).
SmaGMan
approved these changes
Feb 12, 2026
Rexagon
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
[Yes]
Added
s3_proxyBLOCKCHAIN CONFIGURATION MODEL CHANGES
None
COMPATIBILITY
Full compatibility
SPECIAL DEPLOYMENT ACTIONS
Not Required
PERFORMANCE IMPACT
No impact expected
TESTS
No