Skip to content

feat(cli): add support for signature domain in tools#1032

Merged
Rexagon merged 1 commit intomasterfrom
feature/tools-signature-domain
Feb 12, 2026
Merged

feat(cli): add support for signature domain in tools#1032
Rexagon merged 1 commit intomasterfrom
feature/tools-signature-domain

Conversation

@Rexagon
Copy link
Copy Markdown
Member

@Rexagon Rexagon commented Feb 11, 2026

  • Uses new signature context for automatically selecting the required signing algorithm;
  • Bumps tycho-types to a version with a new CellImpl::reference_repr_hash. This required to use some hacky stuff but it is not going to be used anywhere for now.

@github-actions
Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1032

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1032
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1032 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 27.63158% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.43%. Comparing base (5462fa2) to head (d2b7839).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
cli/src/cmd/elect/mod.rs 0.00% 25 Missing ⚠️
cli/src/cmd/tools/bc.rs 0.00% 14 Missing ⚠️
core/src/storage/shard_state/cell_storage.rs 67.85% 9 Missing ⚠️
control/src/server.rs 0.00% 5 Missing ⚠️
cli/src/util/config.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
- Coverage   54.45%   54.43%   -0.02%     
==========================================
  Files         402      402              
  Lines       67545    67577      +32     
  Branches    67545    67577      +32     
==========================================
+ Hits        36782    36787       +5     
- Misses      28945    28972      +27     
  Partials     1818     1818              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rexagon Rexagon added this pull request to the merge queue Feb 12, 2026
Merged via the queue into master with commit 36c3e90 Feb 12, 2026
21 of 23 checks passed
@Rexagon Rexagon deleted the feature/tools-signature-domain branch February 12, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants