Merged
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=1047Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
drmick
approved these changes
Mar 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1047 +/- ##
==========================================
+ Coverage 54.67% 54.69% +0.01%
==========================================
Files 414 414
Lines 69342 69350 +8
Branches 69342 69350 +8
==========================================
+ Hits 37916 37932 +16
+ Misses 29490 29482 -8
Partials 1936 1936 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
[None]
BLOCKCHAIN CONFIGURATION MODEL CHANGES
[None]
COMPATIBILITY
Max wu limit calculation changed. If we update a network under heavy load when the max wu limit was reached it may cause nodes to produce mismatched blocks.
SPECIAL DEPLOYMENT ACTIONS
We should stop a heavy load when updating a network. It is acceptable to have a light load.
PERFORMANCE IMPACT
[No impact expected]
TESTS
Unit Tests
Covered by:
Network Tests
[No coverage]
Manual Tests
Manual tests used