Skip to content

use WAVE_ROUNDS in collator#1047

Merged
SmaGMan merged 2 commits intomasterfrom
refactor/use-wave-rounds-in-collator
Mar 4, 2026
Merged

use WAVE_ROUNDS in collator#1047
SmaGMan merged 2 commits intomasterfrom
refactor/use-wave-rounds-in-collator

Conversation

@SmaGMan
Copy link
Copy Markdown
Member

@SmaGMan SmaGMan commented Mar 4, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None]


COMPATIBILITY

Max wu limit calculation changed. If we update a network under heavy load when the max wu limit was reached it may cause nodes to produce mismatched blocks.

SPECIAL DEPLOYMENT ACTIONS

We should stop a heavy load when updating a network. It is acceptable to have a light load.


PERFORMANCE IMPACT

[No impact expected]


TESTS

Unit Tests

Covered by:

  • test_refill_messages

Network Tests

[No coverage]

Manual Tests

Manual tests used

  • deploy 100k
  • transfers 30k

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1047

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1047
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1047 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@SmaGMan SmaGMan marked this pull request as ready for review March 4, 2026 15:54
@SmaGMan SmaGMan requested review from 0xdeafbeef and drmick March 4, 2026 15:54
Copy link
Copy Markdown
Member

@0xdeafbeef 0xdeafbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.69%. Comparing base (3f2a6f5) to head (b47f93b).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   54.67%   54.69%   +0.01%     
==========================================
  Files         414      414              
  Lines       69342    69350       +8     
  Branches    69342    69350       +8     
==========================================
+ Hits        37916    37932      +16     
+ Misses      29490    29482       -8     
  Partials     1936     1936              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SmaGMan SmaGMan added this pull request to the merge queue Mar 4, 2026
Merged via the queue into master with commit 228a3e6 Mar 4, 2026
23 checks passed
@SmaGMan SmaGMan deleted the refactor/use-wave-rounds-in-collator branch March 4, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants