Skip to content

fix(consensus): don't read DB on overlay change#1059

Merged
Mododo merged 1 commit intomasterfrom
fix/consensus/clean-db-on-overlay-change
Mar 27, 2026
Merged

fix(consensus): don't read DB on overlay change#1059
Mododo merged 1 commit intomasterfrom
fix/consensus/clean-db-on-overlay-change

Conversation

@Mododo
Copy link
Copy Markdown
Member

@Mododo Mododo commented Mar 25, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

None

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full

SPECIAL DEPLOYMENT ACTIONS

Not Required


PERFORMANCE IMPACT

No impact expected


TESTS

Unit Tests

No coverage

Network Tests

No coverage

Manual Tests


Notes/Additional Comments:

@Mododo Mododo requested review from 0xdeafbeef and Rexagon March 25, 2026 12:51
@github-actions
Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1059

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1059
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1059 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@Mododo Mododo self-assigned this Mar 25, 2026
@Mododo Mododo added the C-consesus Consesus module label Mar 25, 2026
@Mododo Mododo added this to the 020 Consensus milestone Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.24%. Comparing base (577e65b) to head (6cec379).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
consensus/src/storage/db.rs 0.00% 19 Missing ⚠️
consensus/src/storage/store.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   57.23%   57.24%           
=======================================
  Files         429      429           
  Lines       71848    71866   +18     
  Branches    71848    71866   +18     
=======================================
+ Hits        41125    41137   +12     
- Misses      28733    28742    +9     
+ Partials     1990     1987    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mododo Mododo added this pull request to the merge queue Mar 27, 2026
Merged via the queue into master with commit a31514e Mar 27, 2026
22 of 23 checks passed
@Mododo Mododo deleted the fix/consensus/clean-db-on-overlay-change branch March 27, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-consesus Consesus module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants