RPC/Overlay rate limits

[pashinov]

No description provided.

[github-actions]

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1074

Available test options:

• Run all tests: gh workflow run network-tests.yml -f pr_number=1074
• Run specific test: gh workflow run network-tests.yml -f pr_number=1074 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

[codecov]

Codecov Report

❌ Patch coverage is 52.89575% with 244 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.93%. Comparing base (6c325bc) to head (689a029).

Files with missing lines	Patch %	Lines
core/src/blockchain_rpc/rate_limits.rs	0.00%	61 Missing ⚠️
rpc/src/endpoint/rate_limits.rs	34.88%	55 Missing and 1 partial ⚠️
rpc/src/endpoint/mod.rs	0.00%	43 Missing ⚠️
util/src/rate_limit.rs	85.21%	24 Missing and 10 partials ⚠️
network/src/overlay/rate_limits.rs	0.00%	33 Missing ⚠️
core/src/node/mod.rs	0.00%	6 Missing ⚠️
network/src/overlay/public_overlay.rs	70.00%	4 Missing and 2 partials ⚠️
rpc/src/endpoint/jrpc/stream.rs	75.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
- Coverage   59.01%   58.93%   -0.09%     
==========================================
  Files         454      459       +5     
  Lines       76372    76880     +508     
  Branches    76372    76880     +508     
==========================================
+ Hits        45072    45308     +236     
- Misses      29202    29455     +253     
- Partials     2098     2117      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

[0xdeafbeef]

I would drop stream rate-limits. Rpc is either behind cloudflare proxy => ConnectInfo always receives cloudflare ip and eventually bans all clients. Or it's behind local proxy => same ban of all clients. You should either get real ip from headers or remove this functional, cause it does more harm than good.

[0xdeafbeef]

lgtm