Merged
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=817Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
3bb0403 to
da4fc5a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 46.82% 46.03% -0.80%
==========================================
Files 317 320 +3
Lines 56395 57461 +1066
Branches 56395 57461 +1066
==========================================
+ Hits 26409 26451 +42
- Misses 28621 29647 +1026
+ Partials 1365 1363 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
da4fc5a to
f5ad2ff
Compare
a5fb0f1 to
5f4814c
Compare
…o get a deterministic result
… the first anchor report after the tune interval elapsed
… lag delta from target bounds
…ams adjustment + use collation_total_wu_price as a reference to calculate target wu price
* bc tools reference * get_blocks_count_between_masters returns exact count * log config watch finished on deref * splitted big func * use macro for avg accumulation
f4de208 to
46abd4e
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added work units tuner service. It is responsible for reporting wu metrics, anchors lag and wu params. And for adjusting wu params. Service behavior is managed by a separate configuration file
wu-tuner-config.jsonthat should be placed in the same directory where the node configuration file is situated. Without the configuration file the default options for wu tuner service will be applied. It will only report to metrics but will not run adjustments.Example
wu-tuner-config.jsonIf we want node to perform adjustment then we should set
Now service supports adjustment via rpc using master key. So the main case is to use service for the wu params adjustment in test networks on one trusted node.
It was assumed that it was sufficient to calculate the target wu params aiming to minimize the anchors lag. But the bunch of tests showed that it is not correct. Under different load profiles, different lag bounds perform best. And seems like we need to consider not only the anchor lag but also other metrics, to decide when to execute adjustment.
So the service will be improved in further tasks.
Now it was used in semi-manual mode to define the optimal wu params on devnet 2.
Target wu params for empty state were calculated with fixed target wu price 0.75
Target wu params for 10kk state were calculated with fixed target wu price 0.6
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
[None]
But added optional config file
wu-tuner-config.jsonBLOCKCHAIN CONFIGURATION MODEL CHANGES
[None]
COMPATIBILITY
Affected features:
On the not empty internals queue it may cause the incorrect refill logic execution.
SPECIAL DEPLOYMENT ACTIONS
[Required]
So we must ensure the queue is empty during the update of 2/3+1 nodes (by stake).
Updated nodes will produce mismatched blocks.
Needs to update Grafana dashboard.
Required to update .params.28 in blockchain config
PERFORMANCE IMPACT
[Expected impact]
Wu calculation for the state related actions updated and will produce more accurate result when state is growing.
TESTS
Unit Tests
[No coverage]
Network Tests
[No coverage]
Manual Tests
Target wu params calculation for empty state
metrics
Comparation of current default and calculated optimal params




metrics