refactor(storage): split block storage#836
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=836Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
==========================================
+ Coverage 46.15% 46.62% +0.47%
==========================================
Files 320 324 +4
Lines 57442 57698 +256
Branches 57442 57698 +256
==========================================
+ Hits 26510 26902 +392
+ Misses 29565 29362 -203
- Partials 1367 1434 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
10m state + 10k tps, new version time diff don't degrade |
559520d to
1c8100a
Compare
with fix it handled 8 hours of 25k tps test
|
4d288fa to
ae17802
Compare
c21019d to
17838b9
Compare
e3701a4 to
5338486
Compare
|
@pashinov PTAL |
994e71f to
7d6da6a
Compare
We only move code here, no logic changes(yet).
f7e1b20 to
c5891c1
Compare



Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
BlockStorageConfig:
archive_chunk_size removed because we don't split archives.
split_block_tasks removed
Not sure if we should set block chunk size in a rpc config, or simply set it as max size which can be sent via
tokio-codec.COMPATIBILITY
Affected features:
Archive contents is byte by byte compatible with prev version, same with archive ids.
No migrations from previous version are provided, so this update should be done via resync.
Old rocks-db tables and migrations were removed to clean up the code.
SPECIAL DEPLOYMENT ACTIONS
Resync nodes one by one.
PERFORMANCE IMPACT
cpu
-18% irq cpu usage.




-44% io wait
-35% kernel space cpu usage
-15% user-space cpu usage
io
-80% io pressure, -65% io utilisation

-30% write traffic

-25% iops

-25% load avg

vm
-30% - 50%
page faults
metrics comparison:
metrics.html.zip
Manual Tests
pkill -9 of validator, was stable af. Re-syncs also worked flawlessly.
todo