Adaptive master block collation frequency#885
Merged
Conversation
0bc0d3f to
36a4a4f
Compare
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=885Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 46.66% 46.81% +0.14%
==========================================
Files 326 326
Lines 58145 58312 +167
Branches 58145 58312 +167
==========================================
+ Hits 27136 27301 +165
- Misses 29587 29590 +3
+ Partials 1422 1421 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
36a4a4f to
1ff8acd
Compare
4ca4c0c to
3fa51d5
Compare
…e collation; and * remove cached chain times from master sync state above next chain time * store all imported anchors info in the cache * simplified anchors cache api * fixed test_import_init_anchors
* not to wait for the next one anchor if master collation was forced by shard
…ad processed externals
…min interval reached
3fa51d5 to
1599f9a
Compare
… cache but remember it as the last imported
drmick
approved these changes
Sep 10, 2025
Rexagon
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
None
BLOCKCHAIN CONFIGURATION MODEL CHANGES
Yes
.params.28.mc_block_max_interval_msCapOmitMasterBlockHistory = 34COMPATIBILITY
Affected features:
Message Processing Algorithm - incompatible, externals reading changed
Collation management - incompatible. New version may choose other anchors for collation
SPECIAL DEPLOYMENT ACTIONS
Required:
Update master block intervals in blockchain config after deployment
Attention:
PERFORMANCE IMPACT
Expected impact
With min interval = 1000 and max interval = 3000 the avg latency will be reduced to ~1.3 sec
metrics
TESTS
Unit Tests
Covered by:
Network Tests
No special coverage
Manual Tests
Manual tests used:
metrics
ping-pong 100 metrics