Skip to content

Conversation

@Mododo
Copy link
Member

@Mododo Mododo commented Dec 23, 2025

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

added node mempool config emit_stats_metrics: bool (default true) to suppress emitting NxN stats metrics

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full

SPECIAL DEPLOYMENT ACTIONS

Not Required


PERFORMANCE IMPACT

No impact expected


TESTS

Unit Tests

No coverage

Network Tests

No coverage

Manual Tests

transfers-30k


Notes/Additional Comments:

* mark if caused by no dag round
@Mododo Mododo requested review from 0xdeafbeef and Rexagon December 23, 2025 19:32
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=988

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=988
  • Run specific test: gh workflow run network-tests.yml -f pr_number=988 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@github-actions
Copy link

❌ Python formatting check failed in CI.

Please run just fmt_py locally and push the updated files.

@Mododo Mododo force-pushed the feature/consensus/stats branch from 12442d1 to 19d412b Compare December 23, 2025 19:34
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 49.57983% with 180 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.25%. Comparing base (4e0f1cc) to head (76f2c0f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
consensus/src/engine/committer_task.rs 0.00% 53 Missing ⚠️
consensus/src/dag/commit/inspector.rs 72.66% 37 Missing and 4 partials ⚠️
consensus/src/dag/verifier.rs 17.07% 34 Missing ⚠️
consensus/src/models/stats.rs 53.33% 28 Missing ⚠️
consensus/src/models/output.rs 0.00% 9 Missing ⚠️
consensus/src/models/dag_point.rs 0.00% 6 Missing ⚠️
consensus/src/dag/dag_point_future.rs 0.00% 4 Missing ⚠️
consensus/src/dag/commit/mod.rs 90.00% 0 Missing and 2 partials ⚠️
consensus/src/models/point_status.rs 0.00% 2 Missing ⚠️
consensus/src/dag/commit/back.rs 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
- Coverage   46.30%   46.25%   -0.06%     
==========================================
  Files         357      360       +3     
  Lines       62235    62585     +350     
  Branches    62235    62585     +350     
==========================================
+ Hits        28820    28950     +130     
- Misses      31914    32125     +211     
- Partials     1501     1510       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mododo Mododo added this to the 020 Consensus milestone Dec 24, 2025
@Mododo Mododo force-pushed the feature/consensus/stats branch from 19d412b to 76f2c0f Compare December 25, 2025 14:33
@0xdeafbeef 0xdeafbeef added this pull request to the merge queue Dec 29, 2025
Merged via the queue into master with commit 9680b4d Dec 29, 2025
22 of 23 checks passed
@0xdeafbeef 0xdeafbeef deleted the feature/consensus/stats branch December 29, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants