Skip to content

IntelliJ wrong Inspection level#17

Merged
bsideup merged 2 commits intobsideup:recordsfrom
nename0:patch-1
Mar 26, 2020
Merged

IntelliJ wrong Inspection level#17
bsideup merged 2 commits intobsideup:recordsfrom
nename0:patch-1

Conversation

@nename0
Copy link
Copy Markdown
Contributor

@nename0 nename0 commented Mar 26, 2020

If you use e.g. Set.of() IntelliJ will only warn you if you set the 'higher than' to 8 not 9 and Set.of() definitely gives a compiler error if you use it in the example project.

TODO update image

nename0 added 2 commits March 26, 2020 13:08
If you use e.g. `Set.of()` IntelliJ will only warn you if you set the higher than to 8 not 9 and `Set.of()` definitely gives a compiler error if you use it in the example project.

TODO update image
@bsideup bsideup added the documentation Improvements or additions to documentation label Mar 26, 2020
@bsideup
Copy link
Copy Markdown
Owner

bsideup commented Mar 26, 2020

@nename0 thank you! Nice catch! 👍

@bsideup bsideup merged commit 6b0ffc5 into bsideup:records Mar 26, 2020
@bsideup
Copy link
Copy Markdown
Owner

bsideup commented Mar 26, 2020

@nename0 oh.... I just noticed (of course after the merge :D) that you submitted it to the records branch, not master. Could you please re-submit to master?

@nename0
Copy link
Copy Markdown
Contributor Author

nename0 commented Mar 26, 2020

Ackchyually this was intentional. I though the records would be merged soon.

bsideup pushed a commit that referenced this pull request Mar 26, 2020
- IntelliJ wrong Inspection level
- update image
bsideup added a commit that referenced this pull request Jun 6, 2021
* Update Maven example: enable JDK 13 / preview in IDEA

* WIP records support

* Document IDEA setup

* Use 14-ea for now

* Update IDEA + Gradle docs

* IntelliJ wrong Inspection level (#17)

* IntelliJ wrong Inspection level

If you use e.g. `Set.of()` IntelliJ will only warn you if you set the higher than to 8 not 9 and `Set.of()` definitely gives a compiler error if you use it in the example project.

TODO update image

* update image

* after-merge fixes

* custom `equals` impl, Java 16 friendly impl

* Point to record on error

Co-authored-by: nename0 <26363498+nename0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants