Fetch build stages data while building pkg_info page #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o page to fix bsiegert#88. This also resolves bsiegert#75 as we have data to disable tabs(buttons) that returned 404 and don't hold any data
This was
linked to
issues
Mar 22, 2025
bsiegert
approved these changes
May 1, 2025
Owner
|
Thanks for bearing with me :) I just approved and merged this. |
Collaborator
Author
Nice! 👍 No worries, I really appreciate feedback and ideas so don't hesitate in the future to brainstorm with me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added simple go routine that fetches in parallel all build stages data while pkg_info page is being built. This solves #88 and #75.
Buttons that are pointing to log files (buiild stages) that don't exist (404) are now disabled. 🎉 HTTP status codes are also captured and available for future improvements if we would like to style output further and highlight errors or similar. 💡
For security and stability reasons
iframeis replaced withpreHTML element. Additionally added link to original log location instead of Go button to make it more visible to the users where the log file is and what are they navigating to. In case this URL is too long, middle of URL is shortened and replaced with....Additionally, CSS and JS code is extracted in external CSS and JS files 🎉
@bsiegert , please review - all feedback welcome!