Enchant Login with Guest UI and Navbar#18
Merged
boytur merged 2 commits intoDevelopmentfrom Feb 25, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the user interface and error handling in the frontend components. The most important changes include updates to the
NavUsercomponent, enhancements to the QR code scanning process, and improved error handling in the authentication hook.User Interface Improvements:
frontend/src/components/NavUser.tsx: Updated the display logic for guest users, added theUsericon in the avatar fallback, and improved the layout of user information. [1] [2]QR Code Scanning Enhancements:
frontend/src/components/qrcode/QrcodeScanner.tsx: Modified the QR code scanning line to span the full width of the container for better visibility.frontend/src/pages/auth/LogIn.tsx: Enhanced the QR code scanning function to handle various JSON formats and provide detailed error messages using toast notifications. [1] [2]Error Handling Improvements:
frontend/src/hooks/UseAuth.tsx: Added error handling with detailed messages and toast notifications for authentication failures. [1] [2]Minor Code Cleanup:
frontend/src/hooks/UseAuth.tsx: Removed unnecessaryReactimport and addedtoastimport. [1] [2]frontend/src/pages/auth/LogIn.tsx: Addedtoastimport for error notifications.