fix: resolve all remaining test failures after monorepo migration#129
Merged
justn-hyeok merged 1 commit intov2from Mar 18, 2026
Merged
fix: resolve all remaining test failures after monorepo migration#129justn-hyeok merged 1 commit intov2from
justn-hyeok merged 1 commit intov2from
Conversation
- TUI tests (9 files): Use Vite resolve.dedupe for react/ink to prevent duplicate React instances in monorepo. Fix ModelSelector data path (model-rankings.json) to correct relative depth. - Orchestrator tests (1 file): Fix vi.doMock paths for bandit-store.js and auto-approve.js to use file-relative monorepo paths. - vitest.config.ts: Replace react/ink aliases with resolve.dedupe, use fs.realpathSync for pnpm store path resolution. Result: 99/99 test files pass, 1506/1506 tests pass, 0 TS errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 10 remaining test failures from monorepo migration:
resolve.dedupefor react/ink/ink-select-input to prevent duplicate React instances. FixModelSelectordata path depth.vi.doMockpaths forbandit-store.jsandauto-approve.jsresolve.dedupe, usefs.realpathSyncfor pnpm store path resolutionResults
Test Plan