Skip to content

Fix BEEF validation issues and refactor validation logic (#211, #96) #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shruggr merged 9 commits into from
Jul 21, 2025
Merged

Fix BEEF validation issues and refactor validation logic (#211, #96) #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ddd5441
Fix BEEF validation stability issue
shruggr Jul 17, 2025
5357904
Update CHANGELOG.md for version 1.2.6
shruggr Jul 17, 2025
f5ea401
Fix README installation instructions
shruggr Jul 17, 2025
bec9eef
Refactor BEEF validation logic
shruggr Jul 17, 2025
867f5c0
Refactor BEEF to use chainhash.Hash instead of strings
shruggr Jul 18, 2025
efd964e
remove comment
shruggr Jul 18, 2025
aec4025
update changelog
shruggr Jul 21, 2025
061f4c6
Update transaction/beef.go
shruggr Jul 21, 2025
6b6da17
Update transaction/beef.go
shruggr Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file. The format

## Table of Contents

- [1.2.6 - 2025-07-21](#126---2025-07-21)
- [1.2.5 - 2025-07-16](#125---2025-07-16)
- [1.2.4 - 2025-06-30](#124---2025-06-30)
- [1.2.3 - 2025-06-30](#123---2025-06-30)
Expand Down Expand Up @@ -40,6 +41,21 @@ All notable changes to this project will be documented in this file. The format
- [1.1.0 - 2024-08-19](#110---2024-08-19)
- [1.0.0 - 2024-06-06](#100---2024-06-06)

## [1.2.6] - 2025-07-21

### Fixed
- Fixed BEEF validation stability issue where `IsValid` returned inconsistent results (#211)
- Fixed BEEF parsing panic when encountering transactions without merkle paths (#96)
- Fixed validation logic to properly check if transactions appear in BUMPs
- Fixed README installation instructions to use `go get` instead of `go install` (#202)

### Changed
- Renamed `SortTxs()` method to `ValidateTransactions()` for clarity
- Improved BEEF validation to handle transactions without source transactions gracefully
- Refactored BEEF implementation to use `chainhash.Hash` directly as map keys instead of string conversions for improved performance
- Added `*ByHash` versions of BEEF methods (`findTxidByHash`, `FindBumpByHash`, etc.) to avoid unnecessary hash/string conversions
- Updated `collectAncestors` to return `[]chainhash.Hash` instead of `[]string`

## [1.2.5] - 2025-07-16

### Changed
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ The BSV Blockchain Libraries Project aims to structure and maintain a middleware

### Installation

To install the SDK, run:
To add the SDK to your Go module:

```bash
go install github.com/bsv-blockchain/go-sdk
go get github.com/bsv-blockchain/go-sdk
```

### Basic Usage
Expand Down
Loading
Loading