Skip to content

Conversation

@dorzepowski
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings September 15, 2025 14:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the AuthFetch functionality to properly fallback to non-authenticated HTTP calls when the initial authentication handshake fails with a non-OK HTTP status. The change replaces string-based error checking with proper error type checking.

  • Introduces a new error type ErrHTTPServerFailedToAuthenticate for standardized error handling
  • Updates the authentication error return to use errors.Join() with the new error type
  • Replaces string-based error detection with proper errors.Is() checking

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
auth/transports/errors.go Adds new error type ErrHTTPServerFailedToAuthenticate for authentication failures
auth/transports/simplified_http_transport.go Updates error return to include the new error type using errors.Join()
auth/clients/authhttp/authhttp.go Replaces string-based error checking with proper errors.Is() type checking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
auth/clients/authhttp/authhttp.go 0.00% 1 Missing ⚠️
auth/transports/simplified_http_transport.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@rohenaz rohenaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohenaz rohenaz merged commit 5c6da9f into master Sep 16, 2025
5 of 7 checks passed
@dorzepowski dorzepowski deleted the fix-inital-handshake-fallback branch September 17, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants