Skip to content

Conversation

@wregulski
Copy link
Contributor

@wregulski wregulski commented Oct 17, 2024

This pull request includes several changes to improve code readability and functionality in the primitives/ec and script packages. The most important changes include removing unused variables, fixing a loop initialization, and renaming a function for clarity.

Code readability and cleanup:

Code clarity:

  • script/script_chunk.go: Renamed the DecodeStringParts function to DecodeScriptHex for better clarity and to accurately reflect its purpose.

Linked Issues / Tickets

No references to specific tasks (maintenance/feedback).

  • [] I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes
  • I have run npm run doc and npm run lint one final time before requesting a review

@shruggr shruggr changed the base branch from master to feat/api-extension October 18, 2024 14:11
@shruggr shruggr merged commit 07e73b2 into bsv-blockchain:feat/api-extension Oct 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants