Skip to content

fix: minor polishing - found when implementing it in SPV-Wallet #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shruggr merged 4 commits into from
Oct 18, 2024
Merged

fix: minor polishing - found when implementing it in SPV-Wallet #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4178516
fix: proper comment for DecodeScriptHex function
wregulski Oct 17, 2024
f5bc7a0
fix: remove unused const fieldOverflowBits
wregulski Oct 17, 2024
6ed7ab7
fix: proper loop on totalKeyShares function
wregulski Oct 17, 2024
68e8b12
Revert "fix: proper loop on totalKeyShares function"
wregulski Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions primitives/ec/field.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ const (
// 2^(fieldBase*i) where i is the word position.
fieldBase = 26

// fieldOverflowBits is the minimum number of "overflow" bits for each
// word in the field value.
fieldOverflowBits = 32 - fieldBase //nolint:varcheck,deadcode,unused // reasons.

// fieldBaseMask is the mask for the bits in each word needed to
// represent the numeric base of each word (except the most significant
// word).
Expand Down
2 changes: 1 addition & 1 deletion script/script_chunk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func PushDataPrefix(data []byte) ([]byte, error) {
return b, nil
}

// DecodeStringParts takes a hex string and decodes the opcodes in it
// DecodeScriptHex takes a hex string and decodes the opcodes in it
// returning an array of opcode parts (which could be opcodes or data
// pushed to the stack).
func DecodeScriptHex(s string) ([]*ScriptChunk, error) {
Expand Down