Skip to content

Conversation

@pawellewandowski98
Copy link
Collaborator

Description of Changes

Activate three methods used in BSV Desktop app:

  • GetSyncChunk
  • ProcessSyncChunk
  • FindOrInsertSyncStateAuth

Linked Issues / Tickets

Closes #676

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run the linter

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR activates three storage provider methods (GetSyncChunk, ProcessSyncChunk, and FindOrInsertSyncStateAuth) for the BSV Desktop application by removing the @NonRPC annotation from the interface definitions and implementing proper authentication in the RPC layer.

  • Removes @NonRPC annotations from three sync-related methods in the interface
  • Implements authentication and authorization for these methods in the RPC storage provider
  • Enables sync functionality to be called via RPC for the BSV Desktop app

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/wdk/storage.interface.go Removes @NonRPC annotations from GetSyncChunk, ProcessSyncChunk, and FindOrInsertSyncStateAuth to allow RPC access
pkg/storage/internal/server/rpc_storage_provider.gen.go Implements authentication checks and delegates to local provider for the three activated methods
Comments suppressed due to low confidence (1)

pkg/storage/internal/server/rpc_storage_provider.gen.go:1

  • This file is marked as code-generated with a 'DO NOT EDIT' header, but the PR modifies it directly. If these changes are intentional manual overrides, the code generation template at tools/client-gen/generator/templates/rpc_storage_provider.tpl should be updated to handle methods with RequestSyncChunkArgs parameter that contains an IdentityKey field requiring validation. Otherwise, these changes will be overwritten the next time code generation runs.
// Code generated by client-gen; DO NOT EDIT.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pawellewandowski98 pawellewandowski98 force-pushed the fix-activate-storage-provider-methods branch from c341dac to e645789 Compare November 17, 2025 12:05
@sonarqubecloud
Copy link

@pawellewandowski98 pawellewandowski98 merged commit 0a81550 into main Nov 17, 2025
10 checks passed
@pawellewandowski98 pawellewandowski98 deleted the fix-activate-storage-provider-methods branch November 17, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes a bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] WalletStorageClient in ts won't backup sync using go-wallet-toolbox

4 participants