Feature/Live Policy #100
Merged
Feature/Live Policy #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Live Policy implmentation - Added mock tests to test the Live Policy implementation - Updated transaction.py to use Live Policy instead of SatoshisPerKilobyte - Made Live Policy the default model in __init__.py in fee_models - Added documentation reference to README.md and wrote documentation for live_policy
Collaborator
Author
|
Added commits that change some of the pre-existing libraries to double check to make sure that the live policy implementation can work via async. Applied changes may not be necessary and currently being reviewed by the engineers at Yenpoint. Upon review the final committed changes may be reverted. |
Enhanced the Transaction.fee() method to support synchronous usage while internally maintaining asynchronous logic. This ensures backward compatibility is not broken. Increased the default TRANSACTION_FEE_RATE to 10 satoshis per kilobyte for more realistic fee calculations. Updated the pytest-asyncio dependency to version 0.24.0. Modified the LivePolicy fallback fee logic to utilize the default TRANSACTION_FEE_RATE constant, ensuring consistency across fee calculations.
- Replaced `async` logic in `live_test.py` with synchronous calls for better compatibility. - Refactored `Transaction.fee()` to include a private helper for asynchronous fee handling. - Updated `LivePolicy` tests to utilize `default_http_client` with mock responses. - Improved test coverage for cache utilization and fallback scenarios. - Removed outdated and unused code in `LivePolicy` test suite.
- Deleted outdated scripts: `create_wallet.py`, `inspect_live_policy.py`, and `live_test.py`. - Updated `__init__.py` to reflect version 1.0.9. - Added release notes for version 1.0.9 in `CHANGELOG.md`.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Based changes on the following
bsv-blockchain/ts-sdk#343
Linked Issues / Tickets
Reference any related issues or tickets, e.g. "Closes #123".
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist:
CHANGELOG.mdwith my changes