Feature/live policy based fees #343
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new LivePolicy fee model that dynamically fetches current transaction fees from the ARC GorillaPool API, replacing the static fee model as the default for transactions.
- Adds a
LivePolicyclass that extendsSatoshisPerKilobyteand fetches live rates from GorillaPool - Implements singleton pattern with intelligent caching and fallback mechanisms
- Updates the default fee model for transactions from static rates to live rates
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/transaction/fee-models/LivePolicy.ts | New fee model class that fetches live rates from ARC API with caching |
| src/transaction/fee-models/index.ts | Exports the new LivePolicy class |
| src/transaction/fee-models/__tests/LivePolicy.test.ts | Unit tests for LivePolicy singleton and caching behavior |
| src/transaction/Transaction.ts | Updates default fee model and documentation to use LivePolicy |
| docs/reference/transaction.md | Updates documentation to reflect new default fee model |
| CHANGELOG.md | Documents the addition of LivePolicy feature |
| package.json | Version bump to 1.6.25 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
https://arc.taal.com/v1/policy Is now public |
ty-everett
left a comment
ty-everett
left a comment
There was a problem hiding this comment.
1.7.1 is released, apologies for the delay on this.
This looks good and is approved from my perspective, it can be patched to 1.7.2 and then released.
|
1.7.3* |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Description of Changes
Add a fee policy which grabs live rates from Gorilla Pool.
Linked Issues / Tickets
Closes #342
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist
CHANGELOG.mdwith my changesnpm run docandnpm run lintone final time before requesting a reviewts-standardnpm version patchso that my changes will trigger a new version to be released when they are merged