Skip to content
Discussion options

You must be logged in to vote

Couple of bugs and an API gap here. Path forward:

1. /merkle_proof returning orphan block — confirmed bug.
util/merkleproof/merkle_proof.go picks BlockIDs[0] with no main-chain filter. For your tx the orphan happens to be index 0. Same problem if a tx is only ever in an orphan block.

Fix: return proof against the main-chain block, or 404 "transaction not in main chain" if none. Tracking in #961.

2. /txmeta missing main-chain indicator — your option 1.
Will add mainChainIndex to the response — single integer pointing at the canonical entry in the parallel arrays, or -1 if tx is orphan-only / mempool. Avoids the per-block round-trip you'd otherwise need. Tracking in #962.

3. /tx/json missin…

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected by mkpuig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants