chore: Improve P2P & mempool robustness and reorg handling

[BlobMaster41]

Description

Multiple robustness and correctness fixes across networking and mempool code:

• BitcoinTransactionVerificatorV2: Harden onBlockChange by adding target/current height tracking, non-poisoning queue (separate caller-visible promise and trailing .catch), retries with exponential backoff, abortable sleep to cancel stale retries, and staleness checks to avoid applying outdated solutions. Adds tests covering retries, abandonment, reorgs, and queue health.

• Mempool.watchBlockchain: Track latestObservedHeight to avoid stale callbacks and compute fullSync against Bitcoin Core tip (with 1-block tolerance) instead of a tautological diff. Adds tests for fullSync behavior.

• P2PConfigurations: Replace hardcoded noAnnounce list with announceFilter using isPrivate to filter private addresses.

• AddressExtractor: Correct protocol parsing by treating valued protocols consistently (avoid mis-parsing components without values).

• P2PManager & PeerChecker: Improve blacklist/unreachable handling (avoid duplicate processing), increase blacklist purge timeout, add isMonitoringHealth guard, skip unreachable peers when dialing/re-adding, better logging, and ensure external dial failures are recorded. Small fixes to event handlers and address filtering.

• BlockWitnessManager: Adjust reorg check from >= to > to avoid incorrect reorg handling when equal.

Overall this commit fixes race conditions, prevents internal queues from being poisoned by transient failures, improves reorg correctness, and tightens P2P peer/address handling. Tests were added for core mempool/verificator behaviours.

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Performance improvement
• Consensus change (changes that affect state calculation or validation)
• Refactoring (no functional changes)
• Documentation update
• CI/CD changes
• Dependencies update

Checklist

Build & Tests

• npm install completes without errors
• npm run build completes without errors
• npm test passes all tests

Code Quality

• Code follows the project's coding standards
• No new compiler warnings introduced
• Error handling is appropriate
• Logging is appropriate for debugging and monitoring

Documentation

• Code comments added for complex logic
• Public APIs are documented
• README updated (if applicable)

Security

• No sensitive data (keys, credentials) committed
• No new security vulnerabilities introduced
• RPC endpoints properly authenticated
• Input validation in place for external data

OP_NET Node Specific

• Changes are compatible with existing network state
• Consensus logic changes are documented and tested
• State transitions are deterministic
• WASM VM execution is reproducible across nodes
• P2P protocol changes are backward-compatible (or migration planned)
• Database schema changes include migration path
• Epoch finality and PoC/PoW logic unchanged (or documented if changed)

Testing

Consensus Impact

Related Issues

---

By submitting this PR, I confirm that my contribution is made under the terms of the project's license.

[Copilot]

Pull request overview

This PR improves robustness and correctness across the P2P layer and mempool/block-change handling, with added regression tests targeting prior audit findings and reorg/race edge cases.

Changes:

• Harden mempool/block-change processing against races and transient failures (staleness tracking, retries/backoff, non-poisoning queues).
• Improve P2P peer handling (unreachable/blacklist behavior, connection-health monitoring guards, address announcement filtering).
• Add extensive tests covering mempool/verificator behavior and reorg/watchdog race scenarios; bump README version.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/witness/WitnessThread.test.ts	Minor test formatting/expectation layout tweaks.
tests/vm/deployContractAtAddress.test.ts	Test formatting refactors; preserves existing behavior.
tests/reorg/watchdog/toctouCurrentHeader.test.ts	Reformats async expect blocks; minor comment formatting.
tests/reorg/watchdog/doubleRevertRace.test.ts	Reformats spies/expect blocks; minor comment formatting.
tests/reorg/blockindexer/stuckFlagRecovery.test.ts	Reformats calls/spies; minor comment formatting.
tests/mempool/MempoolWatchBlockchain.test.ts	New tests validating watchBlockchain fullSync/staleness behavior.
tests/mempool/BitcoinTransactionVerificatorV2.test.ts	New tests validating retry/backoff, staleness abandonment, and queue health.
src/src/poc/networking/PeerChecker.ts	Avoid duplicate “unreachable” handling; centralize failure tracking for external dials.
src/src/poc/networking/P2PManager.ts	Improve unreachable/blacklist handling, prevent duplicate processing, guard health monitoring, skip unreachable peers.
src/src/poc/networking/p2p/BlockWitnessManager.ts	Fix reorg boundary condition by changing >= to >.
src/src/poc/networking/AddressExtractor.ts	Fix multiaddr component parsing by distinguishing valued vs valueless protocols.
src/src/poc/mempool/verificator/bitcoin/v2/BitcoinTransactionVerificatorV2.ts	Add non-poisoning queue, target-height tracking, retries w/ exponential backoff, and staleness checks.
src/src/poc/mempool/manager/Mempool.ts	Track latest observed height and compute fullSync vs Bitcoin Core tip with staleness guards.
src/src/poc/configurations/P2PConfigurations.ts	Replace hardcoded noAnnounce with announceFilter using isPrivate.
README.md	Version bump to v1.0.3.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.