Harden block change handling and scheduling#281
Merged
BlobMaster41 merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
Avoid refreshing challenge solutions while the indexer is far behind by only calling onBlockChange when the block is within 10 blocks of the tip. Ensure verifyBlockHeight is always re-scheduled by moving the timeout into a finally block. Always trigger onBlockChange when the indexer progresses (remove the stale guard), but only advance OPNetConsensus height forward and swallow/set warnings on failures. Wrap transactionVerifier.onBlockChange and fee estimation in try/catch blocks to log warnings instead of failing the flow. Kept the old block-purge code commented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid refreshing challenge solutions while the indexer is far behind by only calling onBlockChange when the block is within 10 blocks of the tip. Ensure verifyBlockHeight is always re-scheduled by moving the timeout into a finally block. Always trigger onBlockChange when the indexer progresses (remove the stale guard), but only advance OPNetConsensus height forward and swallow/set warnings on failures. Wrap transactionVerifier.onBlockChange and fee estimation in try/catch blocks to log warnings instead of failing the flow. Kept the old block-purge code commented.
Type of Change
Checklist
Build & Tests
npm installcompletes without errorsnpm run buildcompletes without errorsnpm testpasses all testsCode Quality
Documentation
Security
OP_NET Node Specific
Testing
Consensus Impact
Related Issues
By submitting this PR, I confirm that my contribution is made under the terms of the project's license.