Merged
Conversation
…tements - Add `logger = logging.getLogger(__name__)` to common.py, core.py, and models/_base.py - Replace all `logging.<level>()` calls with `logger.<level>()` in ofsc/ library code - Remove debug print in `create_resource_location` (core.py) - Remove print in pagination loop `get_all_activities` (core.py) - Remove security leak: print of OAuth bearer token in models/_base.py - Downgrade 5 INFO→DEBUG log calls in pagination loops (get_all_activities, get_all_properties) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
`core/_base.py` and `oauth.py` returned `self._config.baseURL` directly,
which can be None and causes a cryptic `urljoin(None, ...)` error instead
of a clear message.
Now both modules match the pattern already used in `capacity.py` and
`statistics.py`, raising `ValueError("Base URL is not configured")`.
Closes #150
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
Owner
Author
Owner
Author
|
This PR also implements #110 — adds optional httpx event hooks for request/response logging via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ofsc/)print()statements, including one leaking OAuth tokenChanges
pyproject.toml/uv.lock: Bump version to 2.24.1README.md: Rewrite usage examples for clarityofsc/common.py: Add named logger, convert 5logging.*()→logger.*()ofsc/core.py: Remove 2 debug prints, add named logger, convert 10 logging calls, downgrade 5 INFO→DEBUG in paginationofsc/models/_base.py: Removeprint()that leaked OAuth bearer token (security fix), add named loggerTest plan
-W error::DeprecationWarningpasses)ruff checkandruff formatclean on all modified filesgrep -rn "print(" ofsc/returns no matchesgrep -rn "logging\.(debug|info|warning|error|critical)(" ofsc/returns no matches🤖 Generated with Claude Code