Light mode: darken secondary/metadata text for AA contrast#10
Merged
Conversation
The light --muted/--faint greys were washed out: --faint #978996 was only 3.1:1 on white (failed WCAG-AA), used for metadata, star counts, the hero pills and the footer. Darken: - --muted #6A5965 -> #5E5159 (~7.1:1) for more presence - --faint #978996 -> #766678 (~5.0:1, was 3.1 — now passes AA) Both live on @btravstack/theme, so the docs sites' light secondary text (--vp-c-text-2/-3) gets the same lift. Verified: pills 7.1:1, stars/footer 5.0:1; build green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates light-mode text tokens in @btravstack/theme to increase contrast and improve perceived hierarchy (text → muted → faint) without changing primary text or fill accents.
Changes:
- Darkens
--mutedand--faintin the light scheme to meet/beat WCAG AA contrast targets. - Adds/updates inline contrast documentation for the adjusted tokens.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the light-mode review: the page read as washed out because the secondary/tertiary text greys were too light.
Measured (on the
#FBF7F9page)--faint(metadata, stars, hero pills, footer)#978996— 3.1:1 ❌#766678— 5.0:1 ✅--muted(secondary body)#6A5965— 6.1:1#5E5159— 7.1:1 (more presence)--text(17:1),--text-green(6.4:1) and--text-accent(4.6:1) already passed; the wordmark stays the brand-pink--display-accent(large text). Hierarchy text › muted › faint is preserved.These are
@btravstack/themetokens, so the docs sites' light body/metadata text (--vp-c-text-2/-3) gets the same lift once the theme publishes.Verified live-build: pills 7.1:1, stars/footer 5.0:1; build green, no overflow/errors.