fix(docs): anchor the hero glyph + glow to the content column#285
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the VitePress docs home hero styling so the background glyph and the shared theme’s hero glow stay aligned with the centered 1152px content column on wide viewports, instead of drifting toward the viewport edge.
Changes:
- Override
.VPHome::beforepositioning to anchor the shared theme glow to the content column (with the existing ~120px bleed). - Update
.VPHome::afterpositioning (and tweak itsmax-width) so the hero glyph remains aligned with the content column on wide screens.
On wide screens both the glyph and the shared theme's hero glow were anchored to the viewport edge, so they drifted into the far-right corner (a small, detached glyph and a stray halo by the header). Anchor both to the 1152px content column instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Refactored to address the review:
Verified at 1920px: the computed |
btravers
force-pushed
the
fix/hero-anchoring
branch
from
b752d2f to
e39ae55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On wide screens the hero glyph and the shared theme's hero glow were anchored to the viewport edge, so they drifted into the far-right corner — a small, detached glyph and a stray halo next to the header. This anchors both to the 1152px content column so they stay over the hero on any width. Verified at 1920px.
🤖 Generated with Claude Code