fix(interface): fix getTransactionFromBlockIndex and getTransactionCount interfaces#56
Merged
bladehan1 merged 4 commits intobttcprotocol:developfrom Mar 6, 2024
Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #56 +/- ##
===========================================
+ Coverage 13.62% 13.90% +0.27%
===========================================
Files 11 11
Lines 1431 1431
===========================================
+ Hits 195 199 +4
+ Misses 1180 1176 -4
Partials 56 56 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kuny0707
approved these changes
Sep 7, 2023
ClarkChenc
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix getTransactionFromBlockIndex and getTransactionCount interfaces.
Why are these changes required?
These interfaces do not contain state sync event.
This PR has been tested by:
Unit Tests
Manual Testing
Follow up
Extra details