Merged
Conversation
* feature/swagger-edit-usermetadata: (29 commits) chore: udpate usermetadata for swagger v1.0.0-alpha.4 chore: update user reponse dto v1.0.0-alpha.3 chore: add type string to array chore: bump version to 1.0.0-alpha.2 chore: update versions chore: update yarn chore: update invitation acceptance validations chore: linting chore: improve security on invitation flow chore: update for test:ci chore: codacy update chore: update versions chore: lint chore: fix tests chore: codacy lint chore: linting chore: update usermetadata chore: linting ... Conflicts: examples/sample-server-auth/package.json examples/sample-server-auth/src/modules/user/dto/user-create.dto.ts examples/sample-server-auth/src/modules/user/dto/user-update.dto.ts examples/sample-server-auth/src/modules/user/dto/user.dto.ts examples/sample-server-auth/yarn.lock examples/sample-server/package.json examples/sample-server/yarn.lock lerna.json packages/rockets-server-auth/package.json packages/rockets-server-auth/src/domains/invitation/__tests__/invitation-flow.e2e-spec.ts packages/rockets-server-auth/src/domains/invitation/controllers/invitation.controller.ts packages/rockets-server-auth/src/domains/invitation/dto/rockets-auth-invitation-revoke.dto.ts packages/rockets-server-auth/src/domains/invitation/index.ts packages/rockets-server-auth/src/domains/invitation/interfaces/invitation-acceptance-data.interface.ts packages/rockets-server-auth/src/domains/role/services/rockets-auth-role.service.ts packages/rockets-server-auth/src/domains/user/modules/rockets-auth-signup.module.ts packages/rockets-server-auth/src/generate-swagger.ts packages/rockets-server-auth/src/shared/interfaces/rockets-auth-options-extras.interface.ts packages/rockets-server/package.json yarn.lock
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the rockets-sdk monorepo from NestJS 10 to NestJS 11, including comprehensive updates to dependencies, test configuration, and API patterns.
Changes:
- Upgrades all NestJS packages (
@nestjs/*) from v10 to v11, Jest from v27 to v29, and related testing tools - Updates Jest configuration to use the new ts-jest v29 syntax with array-based transform configuration
- Changes role and pet update DTOs from
IntersectionTypepattern toPartialTypepattern, making theidfield optional in base DTOs - Modifies user metadata service to return
nullinstead of throwing exceptions when metadata is not found - Updates
path-to-regexpfrom v3.3.0 to v8.3.0 to support Express 5
Reviewed changes
Copilot reviewed 20 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Root package dependencies upgraded to NestJS 11, Jest 29, and updated Concepta packages to alpha.10 |
| packages/rockets-server/package.json | Core server package dependencies upgraded to NestJS 11 |
| packages/rockets-server-auth/package.json | Auth package dependencies upgraded with all NestJS and Concepta packages updated |
| jest.config.json | Updated Jest transform syntax for ts-jest v29 compatibility |
| jest.config-e2e.json | E2E test configuration updated for ts-jest v29 |
| packages/rockets-server/src/modules/user/user.dto.ts | Added additionalProperties: true to userMetadata fields in Swagger decorators |
| packages/rockets-server/src/modules/user/me.controller.ts | Simplified me endpoint implementation, removed error handling logic |
| packages/rockets-server/src/modules/user-metadata/services/user-metadata.model.service.ts | Changed getUserMetadataByUserId to return null instead of throwing NotFoundException |
| packages/rockets-server/src/modules/user-metadata/interfaces/user-metadata.interface.ts | Updated interface signature to allow null return from getUserMetadataByUserId |
| packages/rockets-server-auth/src/domains/role/dto/rockets-auth-role-update.dto.ts | Changed from IntersectionType to PartialType, making id optional |
| packages/rockets-server-auth/src/domains/role/interfaces/rockets-auth-role-updatable.interface.ts | Updated interface to make all fields including id optional |
| packages/rockets-server-auth/src/domains/user/services/rockets-auth-user-metadata.model.service.ts | Added undefined filtering and JSON serialization for entity updates |
| examples/sample-server/src/dto/pet.dto.ts | Updated PetUpdateDto to use PartialType with explicit required id field |
| examples/sample-server-auth/src/modules/role/role.dto.ts | Updated RoleUpdateDto to use PartialType with explicit required id field |
| packages/rockets-server/CHANGELOG.md | Added changelog entries for versions alpha.1 through alpha.5 |
| packages/rockets-server-auth/CHANGELOG.md | Added changelog entries documenting role update DTO changes and other updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/rockets-server-auth/src/domains/role/dto/rockets-auth-role-update.dto.ts
Show resolved
Hide resolved
...ges/rockets-server-auth/src/domains/role/interfaces/rockets-auth-role-updatable.interface.ts
Show resolved
Hide resolved
...es/rockets-server-auth/src/domains/user/services/rockets-auth-user-metadata.model.service.ts
Show resolved
Hide resolved
Collaborator
Author
|
@copilot review |
Collaborator
Author
Code reviewFound 1 issue:
🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
leoafarias
approved these changes
Feb 16, 2026
tnramalho
added a commit
that referenced
this pull request
Feb 17, 2026
* main: Feature/nestjs 11 (#22) Conflicts: package.json packages/rockets-server/src/modules/user-metadata/services/user-metadata.model.service.spec.ts yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to NestJS 11
Summary
Upgrade the rockets-sdk monorepo to NestJS 11, including packages, examples, and test configuration.
Main Changes
Dependencies
@nestjs/*packages (common, core, platform-express, swagger, typeorm, jwt, passport, config, testing) bumped to ^11.x in root and inpackages/rockets-serverandpackages/rockets-server-auth.sample-server,sample-server-auth) updated to Nest 11 with matching resolutions.yarn.lockand relevantpackage.jsonfiles updated across workspaces.Build & Test Config
jest.config.jsonandjest.config-e2e.jsonupdated (e.g. transform withts-jest,testPathIgnorePatterns).examples/sample-server-auth/jest-e2e.config.jsonadjusted for the new setup.Code – rockets-server
UserMetadataModelServiceInterfaceandUserMetadataModelUpdatableInterface; user-metadata model service is injectable and follows the shared SDK contract./menow returns the authenticated user plus user metadata viaUserMetadataModelService.UserUpdateDtoandUserResponseDtoupdated for user-metadata integration.Code – rockets-server-auth
RocketsAuthRoleUpdatableInterfaceand role update DTO now have optional (partial)idto support PATCH-style APIs where the id is in the URL (e.g.PATCH /roles/:id). Apps that needidin the body can still declareid!: stringon their extended DTO.RocketsAuthUserMetadataModelServiceand related interfaces aligned with the shared contract; user-update and role fixtures updated.Examples
package.jsonandpet.dto.tsupdated for Nest 11 and types.package.json,role.dto.ts, and dependencies updated; role update DTO can redeclareid!: stringif the app requires id in the body.Docs
packages/rockets-server/CHANGELOG.mdandpackages/rockets-server-auth/CHANGELOG.mdupdated with the latest changes and correct dates from git history.Breaking Changes / Impact
*splatinstead of*); nested query params may requireapp.set('query parser', 'extended').idin the role update DTO is now optional; apps that require it in the body should declareid!: stringon their extended DTO.How to Verify
yarn install,yarn build,yarn test,yarn test:e2e.sample-serverandsample-server-auth(build, start, and main flows).