BUniverse & Kaltura Oembed#287
Merged
hirozed merged 6 commits intoDec 2, 2021
Merged
Conversation
smtierneybu
approved these changes
Dec 2, 2021
Contributor
smtierneybu
left a comment
smtierneybu
left a comment
There was a problem hiding this comment.
Looks great, the large comment blocks with detailed are especially helpful. Like the removal of wp-env using gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286.
Changes proposed in this pull request
Sandbox link
Review checklist
CHANGELOG.MDwith a brief explanation of the changes in this pull request in the unreleased section.