Make tests running against Postgres 13 #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjensen
requested changes
May 8, 2021
Member
jonjensen
left a comment
jonjensen
left a comment
There was a problem hiding this comment.
@hasegeli This mostly looks good to me. (Just code-reading, didn't try running it.)
The nolanguage option should be entirely removed IMO, not just commented out, since it looks like it was just incompletely removed in this commit:
commit 054c5796d69e203bc9070079347866d4c513c6a3
Author: Greg Sabino Mullane <greg@endpoint.com>
Date: Wed Jun 29 22:24:53 2011 -0400
I see more nolanguage remnants that could be removed in git grep nolanguage.
This feature is demoved by commit 054c579.
I gave a try to the tests and noticed a few failing. This fixes them so "make test" runs successfully against Postgres 13.2 using the "postgres" user under CentOS 8. A few of the tests were expecting "No matching entries found" when called with "--includeuser postgres --includeuser mycatbeda" and failing because "postgres" owned objects were appearing in the result. I removed "--includeuser postgres" option so they pass. And there were 2 problems on the same_schema tests. Language change message was not matching with the expected because the check was reporting multiple differences not just the language. I changed the pattern to match with this.
Member
Author
|
I removed |
jonjensen
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave a try to the tests and noticed a few failing. This fixes them so
"make test" runs successfully against Postgres 13.2 using the "postgres" user
under CentOS 8.
A few of the tests were expecting "No matching entries found" when called
with "--includeuser postgres --includeuser mycatbeda" and failing because
"postgres" owned objects were appearing in the result. I removed
"--includeuser postgres" option so they pass.
And there were 2 problems on the same_schema tests. Language change message
was not matching with the expected because the check was reporting multiple
differences not just the language. I changed the pattern to match with this.
Also, because the language appears as multiple differences,
"--filter=nolanguage" option of the same_schema check isn't working.
I commented it out for now. We can adress this separetely.