added ExtUtils::MakeMaker 7.64 to configure_requires#155
Merged
turnstep merged 1 commit intobucardo:masterfrom Feb 11, 2026
Merged
added ExtUtils::MakeMaker 7.64 to configure_requires#155turnstep merged 1 commit intobucardo:masterfrom
turnstep merged 1 commit intobucardo:masterfrom
Conversation
Collaborator
|
@rweikusat Now all of the CI tests are failing, not just the Perl 5.36 ones, but I hope that's from the 2026 copyright thing? |
Contributor
Author
esabol
approved these changes
Jan 3, 2026
esabol
approved these changes
Jan 14, 2026
Collaborator
|
@rweikusat : Can you please rebase this PR to see if all the CI tests pass now? (See #156 (comment) for reference.) |
Contributor
Author
|
Will do this on Thursday. I was occupied with other things today and will mainly be travelling tomorrow. |
turnstep
approved these changes
Feb 10, 2026
esabol
requested changes
Feb 10, 2026
| ], | ||
| "configure_requires" : { | ||
| "DBI" : "1.614", | ||
| "ExtUtils::MakeMaker" : "7.64", |
Collaborator
There was a problem hiding this comment.
Nitpick: The other lines use tabs to indent. This line you added uses spaces to indent. Change it to use a tab instead for the sake of consistency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added a configure_requires depenency on ExtUtils::MakeMaker 7.64 to META.json and META.yml so that
perl Makefile.PLagain works with Perl 5.30 because cpanm will now update MakeMaker if the version included with a particular perl version is too old.