Skip to content

added ExtUtils::MakeMaker 7.64 to configure_requires#155

Merged
turnstep merged 1 commit intobucardo:masterfrom
rweikusat:makemaker-update
Feb 11, 2026
Merged

added ExtUtils::MakeMaker 7.64 to configure_requires#155
turnstep merged 1 commit intobucardo:masterfrom
rweikusat:makemaker-update

Conversation

@rweikusat
Copy link
Contributor

Added a configure_requires depenency on ExtUtils::MakeMaker 7.64 to META.json and META.yml so that perl Makefile.PL again works with Perl 5.30 because cpanm will now update MakeMaker if the version included with a particular perl version is too old.

@esabol
Copy link
Collaborator

esabol commented Jan 2, 2026

@rweikusat Now all of the CI tests are failing, not just the Perl 5.36 ones, but I hope that's from the 2026 copyright thing?

@rweikusat
Copy link
Contributor Author

rweikusat commented Jan 3, 2026

If you look at the actual output, you'll see that the 5.30 tests now proceed to actually running tests instead of failing at the configuration stage and that the errors all come from the 99_lint.t copyright check. That's why I did the other pull request. I've created a makemaker-and-copyright branch in my forked repository with both changes and then, all tests pass.
y

@esabol
Copy link
Collaborator

esabol commented Feb 10, 2026

@rweikusat : Can you please rebase this PR to see if all the CI tests pass now? (See #156 (comment) for reference.)

@rweikusat
Copy link
Contributor Author

Will do this on Thursday. I was occupied with other things today and will mainly be travelling tomorrow.

@turnstep turnstep self-assigned this Feb 10, 2026
],
"configure_requires" : {
"DBI" : "1.614",
"ExtUtils::MakeMaker" : "7.64",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: The other lines use tabs to indent. This line you added uses spaces to indent. Change it to use a tab instead for the sake of consistency?

@turnstep turnstep merged commit b9a8863 into bucardo:master Feb 11, 2026
0 of 9 checks passed
@rweikusat rweikusat deleted the makemaker-update branch February 15, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants